stacklok / toolhive / 34218465998

70%

Build Type

push

github

Committed by web-flow

Commit Message

Verify key-signed plugin installs against a public key (#6524)

Verify plugin installs against a public key

Plugins had no key surface at all: a cosign key-pair-signed artifact
could only fail install-time verification, and `--allow-unsigned` could
not rescue it because the artifact is genuinely signed. Skills gained
the install-side key path in #6447; this transliterates it onto plugins,
so a key-signed plugin can be installed project-scoped by supplying the
matching public key, which is then pinned in the lock entry and reused.

The key is the only trust anchor a key-pair bundle can have — no
certificate, no transparency log — so it has to come from outside the
artifact, and dispatch is lock-first: a key-pinned entry verifies
against the key the lock records, and every disagreement with a supplied
key is refused rather than resolved by precedence.

Scope is install-only, matching skills v1: no `--public-key` on upgrade
or sync, and no in-place re-anchor.

Part of #6442

Signed-off-by: Samuele Verzi <samu@stacklok.com>

Coverage Stats

136 of 151 new or added lines in 6 files covered. (90.07%)

57 existing lines in 4 files now uncovered.

79433 of 113019 relevant lines covered (70.28%)

92.63 hits per line