decentraland / archipelago-workers / 34208778045

94%

main: 93%

Pull #131

github

fix(ws-connector): make the shipped-default integration program independent of cwd

The root `yarn test` ends with an aggregate `jest --coverage
--onlyChanged=false --runInBand` whose cwd is the repo root, and
`src/components.ts` loads `['.env.default', '.env']` — relative names,
resolved against the process cwd. From the root those hit the ROOT
`.env.default`, which carries no `HEARTBEAT_FORWARDING_ENABLED`, so the
"left to the shipped default" program in
test/integration/heartbeat-forwarding.spec.ts read `undefined` and failed
two tests. It passed from `ws-connector/` and nowhere else, which is why
it went unnoticed: `build / test` runs the root script, and the
Dockerfile's `RUN yarn test` at WORKDIR /app takes the same path, so
`pr / quay-build-push` failed with it.

`test/components.ts` now loads this workspace's `.env.default` (and `.env`
when present) by a path resolved from `__dirname` before delegating to the
service's own `initComponents`, so a value the service ships is read from
the file that ships it no matter where jest was started. Precedence is
unchanged — `createDotEnvConfigComponent` never overwrites a key the
environment already carries, so the `process.env` override each program
applies in `beforeStart` still wins — and production is untouched: the
service starts with cwd = its own workspace (`yarn workspace ws-connector
start`), where the relative lookup already resolves here.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

115 of 140 branches covered (82.14%)

Branch coverage included in aggregate %.

33 of 33 new or added lines in 3 files covered. (100.0%)

586 of 615 relevant lines covered (95.28%)

16.3 hits per line