PHPOffice / PHPPresentation / 34204645088

94%

push

github

ODPresentation Reader : Give a shape the border its style names (#978)

* ODPresentation Reader : Give a shape the border its style names

The Writer writes a shape's border as the stroke of its graphic style -- `draw:stroke`,
`svg:stroke-width`, `svg:stroke-color` and `draw:stroke-dash` -- and nothing read any of the four
back, so every shape loaded from an ODP wore the border it was born with. This is the
ODPresentation half of #969.

The dash carries the pattern in its name, `strokeDash_lgDashDot` and the nine beside it, which is
finer than the three strokes OpenDocument itself has; a name this library did not write, as
LibreOffice's `Dash_20_5`, is taken as a plain dash rather than handed to the border as a pattern.

`getLineStyle()` comes back single or none. OpenDocument has no attribute for a compound line, so
a border written as `LINE_DOUBLE` cannot say so, the way a shadow cannot say its blur.

A shape is born holding its own `Border` and hands it out rather than taking one, so what the style
says is copied onto it.

`svg:stroke-width` goes into the file as centimetres and is now written to six decimals rather than
three: a point is 127/3600 cm, and three decimals lose about a seventieth of a point, enough that
a four point border came back as 3.997.

* ODPresentation Reader : Take a border rather than copy one onto a shape

`Style\Border` holds the dash styles it can be given, so that the Reader is not the
only place that knows them, and `AbstractShape` takes a `Border` as well as handing
one out. `applyShapeBorder()` sets the border the style names instead of copying its
four properties onto the one the shape was born with.

24 of 24 new or added lines in 3 files covered. (100.0%)

11343 of 12054 relevant lines covered (94.1%)

71.36 hits per line