• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Chaguar / common / 34206250226
82%

Build:
DEFAULT BRANCH: main
Ran 08 Sep 2026 08:48AM UTC
Jobs 1
Files 198
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

08 Sep 2026 08:45AM UTC coverage: 81.924% (+0.09%) from 81.83%
34206250226

push

github

web-flow
[applicationpb] Encode the transaction digest without reflection (#181)

#### Type of change

- Improvement (improvement to code, performance, etc)
- Test update

#### Description

- Add `TxNamespace.QuickASN1Marshal`, which writes the DER of
`asn1_tx_schema.asn` directly. It
sizes the whole encoding first (`tlvSize`, `readSize`, `readWriteSize`,
`writeSize`,
`positiveIntegerSize`), allocates that exact length once, then appends
each field, so the result
is one allocation and every payload byte is copied exactly once.
`ASN1Marshal` is unchanged and
  remains the reference the new encoder is checked against.
- Mark `metadata` `OPTIONAL` in `asn1_tx_schema.asn`. The schema already
did not match what
`ASN1Marshal` produces: the field carries `asn1:"optional"`, so
`encoding/asn1` omits it for a
  nil slice. The schema now says so.
- Check the two encoders against each other everywhere the marshalling
is already tested:
`requireASN1Marshal` (in `asn1_test_exports.go`, so the loadgen's use of
it covers this too)
requires byte equality and unmarshals both results, which puts every
case in `txTestCases` and
  every `FuzzASN1MarshalTxNamespace` input on both paths.
- Add `TestMetadataEdgeCases`, for the one shape the fuzz target cannot
reach: it always passes a
two-element metadata slice, so nil, empty-non-nil, and a single empty
element are never compared.
A nil metadata is absent and a non-nil empty one is an empty SEQUENCE,
which is what
  `encoding/asn1` does for an `optional` field with no default.
- Add `BenchmarkASN1Marshal` over the shapes the doc comment quotes.

#### Additional details (Optional)

Medians of `BenchmarkASN1Marshal` over `-count=5`:

| shape | `encoding/asn1` | `QuickASN1Marshal` |
|---|---|---|
| 2 read-writes, 32-byte keys and values | 7,195 ns, 61 allocs | **237
ns, 1 alloc** |
| 512 read-writes, 32-byte keys and values | 887,108 ns, 8,477 allocs |
**26,460 ns, 1 alloc** |
| 2 read-writes, 1 MB keys and values | 2,433,735 ns, 61 all... (continued)

97 of 97 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

13633 of 16641 relevant lines covered (81.92%)

0.82 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
95.71
-0.86% common/deliverclient/blocksprovider/bft_deliverer.go
Jobs
ID Job ID Ran Files Coverage
1 34206250226.1 08 Sep 2026 08:48AM UTC 198
81.92
GitHub Action Run
Source Files on build 34206250226
  • Tree
  • List 198
  • Changed 1
  • Source Changed 0
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • 3818db81 on github
  • Prev Build on main (#34126671263)
  • Next Build on main (#34451451867)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc