MapColonies / shigola / 3fe151a91

57%

master: 44%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(provider): retire the standard provider interface (MAPCO-11491) (#16)

* refactor(provider): retire the standard provider interface

Shigola had two tile-production paths: an MVT provider returned an encoded
tile, and a standard provider returned features that atlas encoded in Go.
Only the first is reachable from a shipped configuration now that gpkg,
hana and the standard postgis type are gone (MAPCO-11487/11488/11490) --
what was left of the second was the debug provider, two test providers, and
the ~350 lines of atlas.Map that walked layers through simplify, clip,
clean and encode.

All of it goes:

- provider/debug and provider/test/emptycollection are deleted, and
  provider/test keeps only its mvt_test half
- provider.Register, InitFunc, Tiler, TilerUnion, providerType and the
  Drivers type filter are gone; registration has one kind of entry, and
  For returns an MVTTiler
- atlas.Map loses encodeMVTTile and its geometry helpers, Layer loses its
  Provider field, and Encode has one branch
- Encode returns the new ErrNoMVTProvider rather than dereferencing nil for
  a map assembled without one

Two consequences worth calling out. A map may no longer draw layers from
two providers: config already had ErrMVTDifferentProviders for this and it
now applies unconditionally, since every provider is an MVT provider.
And SHIGOLA_OPTIONS' DontSimplifyGeo and SimplifyMaxZoom are removed --
their only reader was the deleted encode path.

The debug provider was documented and shipped, not test scaffolding, so
README.md loses its section too; shigola-docs carries the matching change.

Coverage 44.42% -> 44.27% against ci/coverage-baseline.txt (floor 43.00%).
Every package touched here went up; the total dips because atlas shrank
while the untested geometry trees it fed did not -- those are MAPCO-11492.

MAPCO-11491

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor(config): reject the layer keys the encode path consumed

R... (continued)

Coverage Stats

41 of 58 new or added lines in 8 files covered. (70.69%)

2 existing lines in 2 files now uncovered.

7597 of 17132 relevant lines covered (44.34%)

41.18 hits per line