supabase / etl / 34197045537

78%

Build Type

push

github

Committed by web-flow

Commit Message

deps: make the sqlx TLS backend selectable (#967)

* deps: make the sqlx TLS backend selectable

sqlx's tls-rustls feature is an alias for tls-rustls-ring, so every crate here links ring with no way for a consumer to choose otherwise. sqlx also prefers ring when both backends are enabled, so a consumer cannot override it by adding a feature: the choice has to be made where the dependency is declared.

The library crates now expose tls-rustls-ring and tls-rustls-aws-lc-rs, defaulting to ring so nothing changes for existing users. Binaries keep ring explicitly. This lets a consumer that already uses aws-lc-rs elsewhere avoid linking two cryptographic implementations; etl-postgres is itself such a case, since it declares rustls with the aws-lc-rs feature while its sqlx pulls ring.

Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>

* deps: forward the TLS backend through all ETL crates and fail without one

Each library crate now forwards its tls-rustls-ring or tls-rustls-aws-lc-rs feature to the ETL crates it depends on, so selecting a backend on etl-destinations or etl-maintenance also selects it on etl and etl-postgres. etl-maintenance replaces its hardcoded ring feature with the same selectable pair.

etl and etl-postgres fail at compile time when neither backend is enabled, so a default-features = false build cannot silently drop TLS. The etl-postgres check is unconditional because sqlx is a required dependency used by the source, slots, lag, and store modules.

Binaries, examples, and the fuzz crate select ring explicitly to preserve current behavior. A new CI job builds the library crates with only AWS-LC and verifies that the sqlx ring feature is absent from the resolved feature graph.

Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>

---------

Signed-off-by: Gerd Zellweger <mail@gerdzellweger.com>

Coverage Stats

0 of 1 new or added line in 1 file covered. (0.0%)

12 existing lines in 2 files now uncovered.

55947 of 72416 relevant lines covered (77.26%)

8250.65 hits per line