raystack / frontier / 34191753720

50%

main: 50%

Pull #1915

github

refactor(consent): ask the consent service whether it is enabled

The handler derived "consent is on" from len(Documents()) > 0, which is only
equivalent to the config flag because boot validation rejects an enabled block
with no documents. consent.Service answers it directly now. Enabled() is the
flag and a non-empty document set, so it matches what the handler was already
computing in all four config states, including the one validation rejects.

That removes the two comments whose only job was to explain the inference: the
doc comment on the handler helper, and the one in the test saying an enabled
deployment always has documents. The helper goes with them, because all that
was left of it was a nil guard on a dependency the server always wires and
which no other service on that handler guards.

The boot log asks the same question rather than counting documents, so there
is one definition of enabled rather than two.

Refs docs/rfcs/0002-explicit-consent-at-signup.md

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

85 of 89 new or added lines in 4 files covered. (95.51%)

20629 of 41085 relevant lines covered (50.21%)

15.99 hits per line