ossia / score / 34154826796

28%

Build Type

push

github

Committed by jcelerier

Commit Message

dataflow: refilling a combo box's items is not a domain change

Dragging a control that causes a combo box to be refilled moved the value by
one step and then stopped, left a widget behind, and could leave a right-click
editor on the scene that nothing would close again.

setAlternatives restated the domain, and DefaultEffectItem answers
domainChanged by deleting every control of the process and rebuilding them from
the event loop. So the sequence was: drag the control -> the running object
refills the combo box -> setDomain -> domainChanged -> the control being
dragged is destroyed. The pointer then had nothing to drag, and anything the
destroyed control had put on the scene outlived the item that knew how to take
it down.

The item list is what changed, and alternativesChanged already says so -- the
widgets rebuild from it in place. The domain still follows the items for
whoever reads it later; it just no longer claims the control's shape changed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018oUFSPD1bswcWtvrsq25t3

Coverage Stats

2 of 2 new or added lines in 2 files covered. (100.0%)

1657 existing lines in 32 files now uncovered.

66180 of 236333 relevant lines covered (28.0%)

63513.54 hits per line