CyclopsMC / CommonCapabilities / 34153140538

70%

master-1.21-lts: 70%

Pull #49

github

Take the maximum stack size from the slot when extracting from large slots

The workaround for inventories with slots larger than a vanilla stack read
its maximum stack size from ItemStack.EMPTY. Since the component rewrite an
empty stack carries no MAX_STACK_SIZE component, so that reports 1 rather
than 64.

As a result the branch triggered for practically every extraction, and the
non-simulated path pulled a single item per extractItem call: draining 1000
items out of one slot took 1001 calls instead of 16. Items that stack below
64, such as ender pearls, were affected the same way.

The value now comes from the stack in the slot, which is what item handlers
actually cap a single extraction at.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ACuxaa5QeiZ8mVsEQtwSq1

727 of 1182 branches covered (61.51%)

Branch coverage included in aggregate %.

2098 of 2872 relevant lines covered (73.05%)

3.69 hits per line