Qiskit / qiskit / 34147469940

88%

Build Type

push

github

Committed by web-flow

Commit Message

Apply to_instruction parameter_map to definition.global_phase (#16234)

* Fix to_instruction(parameter_map) for definition.global_phase

`QuantumCircuit.to_instruction(parameter_map=...)` applied the parameter
map to the instruction's `params` and to the gate parameters inside its
`definition`, but not to `definition.global_phase`.  This could leave an
unbound `Parameter` hidden in the definition even though the
instruction's public `params` appeared fully bound; downstream consumers
such as `Operator(...)` then failed with an unbound-parameter error.

The sibling `circuit_to_gate` was already correct: it constructed the
definition circuit from the *substituted* `target = circuit.assign_-
parameters(parameter_dict)` rather than from the original `circuit`.
This fix changes `circuit_to_instruction` to do the same for
`global_phase`, matching the behaviour of `circuit_to_gate`.

Fixes #16181

* Simplify prose

* Add complete `Operator` assertion

We may as well assert, rather than having a no-op "doesn't raise"
statement.

---------

Co-authored-by: gkneighb <gkneighb@users.noreply.github.com>
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>

Coverage Stats

2 of 2 new or added lines in 1 file covered. (100.0%)

7 existing lines in 2 files now uncovered.

116742 of 132856 relevant lines covered (87.87%)

984684.47 hits per line