CyclopsMC / IntegratedTerminals / 34141482526

20%

master-26-lts: 27%

Pull #222

github

Make the wildcard view aliasing explicit, and fix its update order

Two problems with how the alias was handled.

isWildcardViewAliased was a query that mutated: it broke the alias and replaced
the wildcard entry of ingredientsUnsortedViews as a side effect of being asked a
question, and getRawUnfilteredIngredientsView established the alias as a side
effect of a lookup. All of that now happens in updateWildcardViewAlias, called
where the set of known channels changes. The query only reports state, and the
view getter only looks up a map.

The wildcard recursion in onChange also ran before the diff was applied. That
was harmless while the wildcard held its own collection, because the recursion
applied its own copy of the diff. With the collection shared it was not: the
recursion reset the wildcard filtered view and then rebuilt it, from the shared
collection, before the diff reached it. The terminal kept showing the contents
from before the change. The diff is now applied before the recursion.

Found by opening a terminal on a real network and adding an item to a chest
while it was open: the total updated but the item list did not.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Mxjin31W1Lmq5XK1CCe84v

268 of 2272 branches covered (11.8%)

Branch coverage included in aggregate %.

1617 of 6927 relevant lines covered (23.34%)

1.13 hits per line