decentraland / marketplace-server / 34140847972

66%

main: 66%

Pull #405

github

fix: address decentraland-bot review findings

- Key cancelledSignatures/signatureUses by trade_digest when the trade
  has one (V3 marketplaces), falling back to hashed_signature; the guard
  query and OnChainTradeRef now carry trade_digest.
- Give the liveness RPC a 5s timeout via FetchRequest so a hanging node
  cannot stall listing creation.
- Check open orders sequentially and return at the first live one.
- Cap the on-chain fan-out: more than five indexer-open orders keeps the
  DB's answer instead of issuing that many RPC reads.
- Log only the error message, not the ethers error object that carries
  the RPC request.
- Tests: digest-keyed trades, mixed-liveness and early-return ordering,
  the cap, and the contractSignatureIndex call assertion.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

1844 of 3181 branches covered (57.97%)

Branch coverage included in aggregate %.

31 of 31 new or added lines in 3 files covered. (100.0%)

3242 of 4563 relevant lines covered (71.05%)

28.8 hits per line