decentraland / marketplace-server / 34138945227

66%

main: 66%

Build Type

Pull #405

github

Committed by RocioCM

Commit Message

fix: address decentraland-bot review findings

- Type chain_id as ChainId on OnChainTradeRef instead of number.
- Call isTradeLiveOnChain through an arrow so map's index/array never
  leak into its parameters; the test now asserts the single argument.
- Drop the unused id column from the duplicate-order guard so the row
  shape matches OnChainTradeRef.
- Also compare the contract-wide signature index on chain, the one
  status branch the SQL checked and the helper did not.
- Reword the docstring to "fails safe", which is what an unreachable
  RPC does from the caller's side.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

Pull Request Pull Request #405: fix: let a seller relist as soon as their cancellation is on chain

Coverage Stats

1838 of 3174 branches covered (57.91%)

Branch coverage included in aggregate %.

26 of 29 new or added lines in 3 files covered. (89.66%)

12 existing lines in 3 files now uncovered.

3235 of 4556 relevant lines covered (71.01%)

28.76 hits per line