rieske / trans / 34136371682
94%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 273
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 94.424% (-0.05%) from 94.474%
34136371682

push

github

web-flow 
fix: internal codegen invariants fail in release builds too (#305)

assert is compiled out by NDEBUG, which is the default build type, so
invariants that code generation relies on were unchecked in the build
people actually ship. This is the divergence that hid the Result
annotation bug, where the assert was the only thing between a missing
annotation and dereferencing nullptr.

Nine sites asserted a pointer and then dereferenced it: the declarator
holder, IndexPlan, FieldPlan, the member base symbol, the string literal
rodata label, the postfix PreOperation, the enclosing procedure of a
scratch value, the assigned register, and the operator behind a lexeme.
In a release build a missing one was a null dereference rather than a
diagnosable failure.

Five more asserted and then continued, which is worse than a crash
because it emits wrong assembly and says nothing. Address::frameBase and
offsetBytes answered for a global home with the stack pointer and zero,
so a global reached memoryOperandAt as a frame slot; label() answered for
a frame slot with an empty symbol; and a duplicate frame home
registration was dropped, leaving the value bound to the first home.

All fourteen now raise an internal compiler error in every build type,
matching the guards used for the parse stack, the Result annotation and
the open function scope.

The remaining asserts are left alone: they guard states whose dereference
already routes through a throwing accessor, or that throw of their own
accord.

15851 of 16787 relevant lines covered (94.42%)

153168.45 hits per line

Coverage Regressions

Lines Coverage ∆ File
18
96.35
 -0.31% home/runner/work/trans/trans/src/codegen/StackMachine.cpp
5
95.79
 0.0% home/runner/work/trans/trans/src/codegen/CodeGeneratingVisitor.cpp
3
83.33
 -11.9% home/runner/work/trans/trans/src/codegen/Address.h
1
81.25
 -1.73% home/runner/work/trans/trans/src/types/Operator.h
Jobs
ID Job ID Ran Files Coverage
1 34136371682.1 273
94.42
 GitHub Action Run
Source Files on build 34136371682