roundup-tracker / roundup / 34133164505

75%

Build Type

push

github

Committed by rouilj

Commit Message

bug: reverting create_inner/set_inner changes and default_value support.

changeset: 8795:f67948a018ec to make default_value work broke a number
of tests.

The changes to create_inner and set_inner broke tests in filtering,
quiet journals etc. I assume there was some change to the back end
data or some changes in flow that I didn't realize.

In this commit, check_inner() is restored in rdbms_common and
back_anydbm.  create() still lives in hyperdb. Reverted changes to
set_inner() since the changes were to support using default_value.

This commit makes using 'default_value=...' change the value returned
from get_default_value() as it used to. default_value does not set a
value for the property on create.

Docs updated to remove default_value support but kept new docs that
are still true (e.g. MultiLink has no support for default_value).

I use testmon to select tests that exercise the code paths I change.
When a change I make gets different data in the db or internal state,
it can't always see the impact of that via code coverage metrics so
doesn't run all the tests that would be affected.

Coverage Stats

195 of 211 new or added lines in 2 files covered. (92.42%)

360 existing lines in 5 files now uncovered.

19153 of 25435 relevant lines covered (75.3%)

5.23 hits per line