FlexMeasures / flexmeasures / 34120784517

86%

Build Type

push

github

Committed by web-flow

Commit Message

Make train-period the one way to limit how much history a forecaster trains on (#2482)

* forecasting: go back no further than either training bound asks for

Context:
- train-start and train-period each say how far back to train, and a config may state both.
- Since #2178 a stated train-start won outright, so a stated train-period could no longer narrow it, and a config asking for 30 days of history could train on a year without saying so.
- That #2178 change was right about the default: train-period carries a load default of 30 days, which used to narrow a stated train-start silently, which is what issue #2186 was about.
- The two cases were indistinguishable, because by the time the config is loaded a stated period looks exactly like a defaulted one.

Change:
- Remember at load time whether train-period was asked for, rather than defaulted to.
- Let a stated train-period take part in the decision again, so stating both goes back no further than either asks for, while a defaulted one still stays out of the way of a stated train-start.
- Say at debug level which bound decided, and how far back the window reaches.

The resulting window is unchanged for every config that does not state both.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HeRZd2nDDShZTE8ZmbERzn
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* tests: cover which training bound decides the window

Context:
- The window a config resolves to had no test of its own, so the change of precedence in #2178 could pass unnoticed.

Change:
- Cover each shape a config can take: neither bound stated, either one stated, and both stated with either one asking for less.
- Assert that a stated train-period is told apart from the defaulted one, since that is what lets the two cases differ.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HeRZd2nDDShZTE8ZmbERzn
Signed-off-by: F.N. Claessen <cl... (continued)

Coverage Stats

33 of 34 new or added lines in 2 files covered. (97.06%)

1 existing line in 1 file now uncovered.

18422 of 21686 relevant lines covered (84.95%)

0.85 hits per line