kubernetes-sigs / kubebuilder / 34118857861

87%

push

github

🐛 fix(go/v4): resolve create webhook target when several share a GVK (#5932)

* fix(go/v4): resolve create webhook target by domain when several share a GVK

create webhook matched a recorded resource by Group, Version and Kind and took
the first hit. When a project records more than one external resource sharing a
GVK under different domains, the webhook was bound to whichever entry the PROJECT
file listed first, and passing --external-api-domain to select another failed
outright.

updateResourceFromConfig now collects every Group/Version/Kind match: a single
match is recovered as before; with several, --external-api-domain selects one,
otherwise the non-external (core/project) entry is used, preferring the project
when a core and project entry collide; it refuses and names the recorded domains
when it still cannot tell which was meant, leaving the PROJECT file unchanged. An
unmatched --external-api-domain is only rejected when no --external-api-path is
given, so a further variant can still be added.

create api is unaffected; it already looks resources up by the full GVK.

* fix(go/v4): address review on ambiguous webhook resource resolution

- clarify --external-api-domain help text (webhook.go, api.go): it is a
  suffix combined with --group, e.g. --group cert-manager
  --external-api-domain io => cert-manager.io
- render an empty recorded domain as <empty> in the resolution error so
  the list is not "(domains: , io)"
- correct the updateResourceFromConfig doc comment: the G/V/K lookup is
  for the multi-match case (not because res carries the project domain);
  describe external/core/project kinds and the resolveDomain dependency
- document in selectNonExternal why there is no --external-api-path escape
  hatch without a domain (a path-only new resource would be stamped with
  the project domain)
- flatten the resolution switch so selectByDomain is not called twice
- strengthen tests: assert domain and webhooks on the untouched entries,
  and as... (continued)

81 of 82 new or added lines in 2 files covered. (98.78%)

8844 of 10132 relevant lines covered (87.29%)

329.39 hits per line