rieske / trans / 34118940464
94%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 274
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 94.417% (+0.001%) from 94.416%
34118940464

push

github

web-flow 
fix: stop internal errors following a semantic diagnostic (#298)

A static initializer whose operand failed analysis printed the real
diagnostic and then an internal one:

    int x = nosuch;
    -> error: symbol `nosuch` is not defined
       Error: expression type is not set

Nineteen error paths in semantic analysis report and return without
typing the expression, which is deliberate: analysis continues so a
single run reports more than one problem. Readers are expected to
probe first, and Expression.h says so. Every reader does except
evaluateStaticInit, which reaches getType() through assignSourceType.
Guarding that one reader covers all nineteen, and each of them now
emits exactly one diagnostic. hasExpressionType() is the precise
predicate: it is what getType() throws on, and the dual-type branch
beside it is only reachable when a Result was set as well.

Separately, isAtFileScope() returned scopeIdStack.empty() while the
vector it guards is functionScopes. enterBlockScope() can push a scope
id with no function scope, at which point the predicate claimed a
function was open and the reads it protects ran on an empty vector.
Defining it on the stack it guards makes those reads unreachable
whatever opens a block scope. All thirteen callers want "no function
scope open", including two that had open-coded functionScopes.empty()
next to it.

Both changes are hardening rather than fixes for anything currently
reachable: the constructs that produced the untyped expression and the
functionless block scope are already rejected earlier.

15575 of 16496 relevant lines covered (94.42%)

155805.49 hits per line

Jobs
ID Job ID Ran Files Coverage
1 34118940464.1 274
94.42
 GitHub Action Run
Source Files on build 34118940464