Logflare / logflare / 34112280211-1

83%

Build Type

push

github

Committed by web-flow

Commit Message

fix: build the rules tree and its rule lookup from one snapshot (#3937)

`RulesTree.matching_rules/2` was a two-step lookup. The tree stored bare rule
ids, and `Rules.Cache.get_rules/1` resolved each id to a `Rule`. The two steps
read different databases:

- `rules_tree_by_source_id/1` goes through `ContextCache.apply_fun/3` and so
  `Repo.apply_with_replica/3` — a randomly picked read replica.
- `get_rules/1` called `Rules.get_rule/1` directly inside the
  `ContextCache.fetch/3` fallback, bypassing the replica that the singular
  `Rules.Cache.get_rule/1` uses, and so read the primary.

After a rule delete committed on the primary, a tree rebuilt from a lagging
replica still carried the dead id, and resolving it against the primary returned
`nil`.

`Rules.rules_tree_by_source_id/1` already reads the rules it builds the tree
from, then discards them. Keep them and cache both halves in one entry, so the
ids and the rules come from one query, one cache entry and one bust. An id the
tree can match now always resolves.

Drops `Rules.Cache.get_rules/1` and its private `fetch_rule/2` — the tree was
their only caller.


Claude-Session: https://claude.ai/code/session_013kMNrQA6RgNdnjwA2QQuhf

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

Coverage Stats

3 of 3 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

14681 of 17861 relevant lines covered (82.2%)

2210.88 hits per line