kubernetes-sigs / inference-perf / 34107537952

80%

push

github

fix(otel): preserve tool results from the response field (#774)

OTel traces using the standard `tool_call_response.response` field
currently replay with empty tool content. Read `response` when the
legacy `result` field is absent, both when building OpenAI-compatible
graph messages and when reconstructing input text. Existing field
precedence, including explicitly empty legacy results, is preserved.

Fixes #665.

Regression tests cover `parts` and `content` containers, tool/user role
normalization, structured response values, empty/missing values, and
legacy field precedence. Before the fix, 16 new cases fail because the
tool content is discarded.

Validation:

- Full unit suite with coverage: 1266 passed, 7 skipped.
- OTel replay, trace graph, and reconstruction tests: 156 passed.
- `pdm run validate`: passed (formatting, lint, strict types, CLI
documentation sync).
- Mock-client benchmark: passed and generated reports.
- `pdm run check:cov`: passed; current coverage 77.96%, above the 77%
floor.

The standalone license-header checker rejects the touched files'
existing 2025 headers (and leading shebangs); those headers are
unchanged from main.

Co-authored-by: Comfident <gcomfident@gmail.com>

3 of 3 new or added lines in 2 files covered. (100.0%)

9070 of 11617 relevant lines covered (78.08%)

0.78 hits per line