solidjs / solid / 34091142142

72%

main: 89%

push

github

fix(signals): adoption diffs against the pending view instead of cancelling the draft (#3296)

Follow-up to aed21ac8. Reconcile and returned-object adoptions are writes
like any other: they must diff against the view the nodes were LAST TOLD —
the draft's pending backing when one preceded them — exactly as a second
draft set does. The interim cancel pass rewound the nodes to committed so
a committed-based diff would be right; the base was wrong, not the nodes.

- target.ab replaces the boolean `adopted`: the adoption diff base, non-null
  when the backing was swapped this batch. adoptPB takes the (materialized)
  draft pb when one exists, else keeps an existing base or the pre-batch
  committed; foldOlds' entry stays the committed identity for the CAS.
- drainFolds notifies when base !== v, which also covers adoption back to
  the identical committed raw after a draft (the flag could not).
- applyAdopt's node-notify base is prev (t.pb ?? t.v), which it already had.
- cancelDraftNotifications / writtenKeysBound removed; notifyWrites restored.

Size: createStore scenario 14374 B, 17 B under the pre-fix baseline (cap
back to 14.42 KB); hydrating-store 26423 B (26.45 KB, brotli drift).

Co-authored-by: Claude via Cursor <noreply@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>

515 of 783 branches covered (65.77%)

Branch coverage included in aggregate %.

764 of 998 relevant lines covered (76.55%)

14.94 hits per line