opendefensecloud / artifact-conduit / 34090661669
85%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 7
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 84.322% (+0.5%) from 83.792%
34090661669

push

github

web-flow 
refactor: use envtest sideloading from dev-kit (#473)

## What

Replace this repository's copy of the envtest sideload script with the
shared `envtest-binaries-sideload` target from dev-kit v2.1.0.

Refs opendefensecloud/odd-internal#59

## Why

`setup-envtest`'s release index lags upstream Kubernetes, so bumping
`ENVTEST_K8S_VERSION` to a fresh release breaks `make test` until
controller-tools catches up. The workaround — sideloading the binaries
straight from `dl.k8s.io` and the etcd GitHub releases — was landed
independently in three repositories and then diverged: only
solution-arsenal's copy gained macOS support, etcd `.zip` handling, and
a `shasum` fallback for hosts without `sha256sum`. dev-kit v2.1.0 ships
that superset, so the local copy here is pure duplication of an
already-outdated variant.

## Testing

- `make envtest-binaries-sideload` cold — fetched the script to
`bin/envtest-sideload-v2.1.0.sh`, sideloaded K8s 1.36.1 with etcd 3.6.8,
checksums verified.
- Re-run warm — no re-download.
- Re-run warm with the network blackholed
(`HTTPS_PROXY=http://127.0.0.1:1`) — exit 0, confirming `make test`
keeps no hard network dependency once the cache is warm.
- `shellcheck` over the remaining tracked shell scripts — clean.
- `make test` — full suite green.
- Docs change is text only: two hardcoded `ENVTEST_K8S_VERSION=1.34.1`
values in the developer guide were stale against the Makefile's `1.36.1`
and now point at the Makefile instead.

## Notes for reviewers

This bumps `DEV_KIT_VERSION` across a major boundary (v1.0.15 to
v2.1.0). dev-kit v2.0.0 disabled the `osv-scanner` pre-commit hook by
default, and this repository does not enable it explicitly, so that hook
stops running locally. Vulnerability scanning continues to run in CI,
which is what dev-kit's change intended.

The `ENVTEST_K8S_VERSION ?= 1.36.1` pin deliberately stays in this
Makefile rather than moving to `common.mk`: Renovate's shared `k8s`
preset matches it here and groups it wit... (continued)

796 of 944 relevant lines covered (84.32%)

1300.56 hits per line

Jobs
ID Job ID Ran Files Coverage
1 34090661669.1 7
84.32
 GitHub Action Run
Source Files on build 34090661669