dennisdoomen / reflectify / 34088497543

98%

main: 98%

push

github

Add GetMethods(MemberKind) with hierarchy semantics matching properties/fields (#185)

* Add GetMethods(MemberKind) with hierarchy semantics matching properties/fields

Closes #153.

- Reflector now also loads methods, walking the type hierarchy the same
  way it already does for properties and fields: Static selects either
  static or instance methods (never both), and private methods declared
  on base types are included.
- Property/event accessors, indexers and operators are always
  IsSpecialName and are excluded by default, so GetMethods only returns
  the methods a caller would normally write and call explicitly.
- Overridden methods and methods hidden with `new` are de-duplicated so
  only the most derived one is returned, while overloads (same name,
  different parameters) are all kept. Normal methods take priority over
  explicitly implemented or default interface methods with the same
  signature, mirroring OrderedPropertyCollection's rules.
- Fixed FindMethod/HasMethod to use the new hierarchy walk instead of a
  flat Type.GetMethods(BindingFlags) call. This corrects the
  inconsistency called out in the issue: MemberKind.Static now must be
  requested explicitly to match static methods (previously both
  instance and static were always included), and private base-type
  methods are now found as well, consistent with property/field lookup.
- Added MethodInfoExtensions.IsExplicitlyImplemented, mirroring the
  existing PropertyInfoExtensions member.
- Added focused specs for GetMethods (visibility, static, explicit and
  default interface methods, override/hiding de-duplication, overload
  preservation, special-name filtering) and updated the FindMethod
  static-method spec for the corrected behavior.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

* Close coverage gaps around GetMethods and the FindMethod hierarchy walk

Adds the specs a coverage review found missing on the GetMethods work.

MethodInfoExtensions.Is... (continued)

523 of 554 branches covered (94.4%)

Branch coverage included in aggregate %.

122 of 122 new or added lines in 3 files covered. (100.0%)

995 of 998 relevant lines covered (99.7%)

2204448.65 hits per line