block / mysql / 34064724971

85%

master: 85%

Build Type

Pull #5

github

Committed by morgo

Commit Message

readonly: test the exemption lifecycle, log the discarded error

Three fixes from review.

The exemption flag had no test driving it. TestReadOnlyTxIsExempt proved
handleErrorPacket reads it, but set the field itself, so three mutations
survived the full suite: begin setting it unconditionally, and either of
Commit or Rollback failing to clear it. The first is the worst — every
transaction exempt means any connection that has ever run a BeginTx stops
rejecting read-only errors for the rest of its life in the pool, the feature
silently off. TestReadOnlyTxLifecycle drives begin/Commit/Rollback against a
mock server and kills all three.

ResetSession now clears the flag too. Every sql.Tx ends in Commit or Rollback
so this should be unreachable, but the stuck direction is the unsafe one and
a pooled connection's assumptions belong there.

The server's error was discarded with nothing logged. For the failover this
is written for that is fine — database/sql retries and the caller sees
nothing. For a target that stays read-only it is not: the retry budget burns,
the caller gets a bare driver.ErrBadConn, and the one string that named the
problem was assembled nowhere. Log it before closing.

README: name the 1290s that are not failover (secure_file_priv,
super_read_only, innodb_read_only, --skip-grant-tables), and say plainly what
a deliberately read-only deployment should do now that the option is gone.

Pull Request Pull Request #5: Always reject read-only connections

Coverage Stats

50 of 50 new or added lines in 4 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

3584 of 4232 relevant lines covered (84.69%)

331056.14 hits per line