umputun / revdiff / 34064026056

92%

push

github

feat(ui): show status bar icons beside their toggle keys in help (#352)

* feat(ui): show status bar icons beside their toggle keys in help

The help overlay listed every toggle key but never the glyph the status
bar renders for it, so the icon legend lived only in the README table.
Each View and Search row now carries its glyph in front of the
description, resolved through the same live keymap as the key column so
custom bindings and chords stay correct. Rows in those sections without
a glyph are indented to keep the description column straight.

Related to #351

* test(fsutil): cover the write and close failure cleanups of AtomicWriteFile

Split the fill-close-rename step into commitTemp behind a TempFile
interface so a moq mock can fail the write or the close. Both paths
now prove the temp file is removed and the target is left untouched.
Package coverage goes from 70.6% to 100%.

* refactor(ui): render status bar glyphs from the single statusIconForAction map

statusModeIcons carried its own copy of the twelve glyphs, so an edit in
one place and not the other would put the status bar and the help legend
out of step. The status bar now reads each glyph from the map by action.

* refactor(fsutil): unexport the tempFile interface and mock it in-package

TempFile had no caller outside the package; it was exported only so a
sibling mocks package could name the generated type. Follow the
app/signal.go precedent instead: the interface stays unexported and moq
writes temp_file_moq_test.go into fsutil itself.

* docs: say the help overlay pairs each icon with the key that controls it

"toggles" was wrong for two rows: / opens the search prompt and the
search icon lights on matches present, Space marks a file and the
reviewed icon reflects that state.

33 of 33 new or added lines in 3 files covered. (100.0%)

11842 of 12933 relevant lines covered (91.56%)

3454.47 hits per line