archetech / archon / 34058238627

87%

push

github

fix(ci): Compare every service config, and read its booleans correctly (#1064)

* fix(ci): Compare every service config, and read its booleans correctly

The compose-defaults guard recognised a JavaScript boolean only as the
ternary `VAR ? VAR === 'true' : false`, so the repo's commoner
`VAR === 'true'` went uncompared. Fixing the matcher alone would have
changed nothing: all four bare sites are in drawbridge, zcash and satoshi,
and CONFIGS named five files out of eighteen. Thirteen services had no
default compared against anything.

Glob the configs instead, and read the JS ones with the TypeScript compiler
rather than by pattern. The bare comparison appears inside the ternary, so a
regex for it also fires on the nested one and records false for the four
REIMPORT variables whose default is true.

Widening surfaced two real disagreements, both in Herald:

- ARCHON_HERALD_WALLET_URL built the login challenge link, which the
  visitor's browser follows, and composed nodes handed out localhost:4228 --
  an address that only resolves for a visitor sitting on the node. Compose
  now carries the same reachable default the code does. A third copy of that
  literal in oauth/index.ts read the environment itself rather than importing
  WALLET_URL, so the OAuth and challenge paths could drift apart.

- ARCHON_HERALD_NAME is the identity Herald issues name credentials from and
  the source of its IPNS key name. Every composed node already runs as
  `herald`; only a bare `node` run reached `name-service`. The code default
  follows compose, along with the IPNS-key fallback in the standalone compose
  file and the three places the docs quoted it.

An empty code default is now skipped as the absence of one, the way an empty
compose default already was.

Closes #1055

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYGMfX3foBcVqP7AQNXjWj

* fix(ci): Read helper-call defaults, and finish the herald rename

Two gap... (continued)

3926 of 4515 branches covered (86.95%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 2 files covered. (100.0%)

8573 of 8999 relevant lines covered (95.27%)

721.32 hits per line