aio-libs / multidict / 34024160706

87%

push

github

Fix proxy reinitialization reference leak (#1419)

<!-- Thank you for your contribution! -->

## What do these changes do?

Fixed the C extension to release a proxy's previous target when its
``__init__`` method is called again. Added regression tests for both
proxy types and implementations.

## Are there changes in behavior for the user?

Yes. Explicitly reinitializing a proxy no longer retains its previous
target and its contents.

## Is it a substantial burden for the maintainers to support this?

No. The change uses CPython's standard refcount-safe replacement macro
and is covered by the existing test matrix.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [x] Unit tests for the changes exist
- [ ] Documentation reflects the changes (N/A, no user-facing
documentation change)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A, this repository has no `CONTRIBUTORS.txt`)
- [x] Add a new news fragment into the `CHANGES/` folder

Drafted with GitHub Copilot App 1.0.83-5; pending human review.

---------

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

627 of 1254 branches covered (50.0%)

Branch coverage included in aggregate %.

10 of 19 new or added lines in 1 file covered. (52.63%)

4133 of 4333 relevant lines covered (95.38%)

1.91 hits per line