solidjs / solid / 34016321311

72%

main: 89%

push

github

revert(web): restore eager element creation in Dynamic (#3187 deferral; fixes #3291)

Reverts 3c357fbc. #3187 fixed the HTML/SVG namespace of the four ambiguous
tag names (a, script, style, title) rendered through <Dynamic> inside SVG
content by deferring element creation into a thunk the consuming insert()
pulls, so the live insertion parent could supply the namespace hint. That
changed render semantics for a primitive the ecosystem builds on:

- CSR/hydration asymmetry: hydration still created eagerly; CSR deferred.
- spread and ref callbacks ran at first insertion instead of component
  creation, or never for content that is not inserted.
- For <Dynamic> inside <Portal>, whose insert runs from a schedule:true
  render effect, the ref write moved into the render phase of the flush —
  where createTrackedEffect readers never observe it (a latent engine gap;
  tracked effects run in the same pass's user queue with committed
  visibility, before the staged value commits). Every Kobalte popper
  rendered unpositioned on rc.6 (#3291).
- Partial by construction: content resolved outside an insert (children()
  helper) had no insertion parent and fell back to HTML anyway.

There is no fix for the namespace edge that keeps creation eager — the
namespace must be known at createElement time and the parent is not known
before insertion — so the limitation is accepted, as it was throughout 1.x:
use a static element for ambiguous tags inside SVG.

Pins: string-component Dynamic's memo yields the element and its ref fires
synchronously at creation; a Dynamic ref inside a Portal wakes a tracked
effect. The tracked-effect visibility gap itself is tracked separately.

Co-authored-by: Cursor <cursoragent@cursor.com>

515 of 783 branches covered (65.77%)

Branch coverage included in aggregate %.

764 of 998 relevant lines covered (76.55%)

14.95 hits per line