bleedingdeacons / reach / 34001248867
86%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 92
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 86.322% (+0.02%) from 86.306%
34001248867

push

github

web-flow 
refactor: use Unity's member password store (#110)

* refactor: use Unity's member password store

Reach kept wp_reach_credentials and Fellowship kept an identical
wp_fellowship_credentials, so a member who set a password in one could
not sign into the other with it, and a reset in one left the other
stale with nothing anywhere to say so. A member has one password, not
one per app.

PasswordCredential, the repository contract and the wpdb implementation
are gone from here; they are Unity's now, over wp_unity_credentials.
ReachServiceProvider no longer binds one — Unity registers it into the
same container, so PasswordAuthenticator resolves it unchanged. Schema
no longer installs the table, because Unity installs its own on a
version change, and migrates the old rows while it is there.

The two repository test files went with the class. Their coverage lives
in Unity now, alongside tests for the migration they did not have. The
container fixtures seed Unity's InMemoryPasswordCredentialRepository in
place of the binding Reach used to make.

1186 tests, PHPCS clean, PHPStan level 8 no errors, no new baseline
entries.

Depends on bleedingdeacons/unity#68.

* refactor: use the shared credential double too

Reach kept a local InMemoryPasswordCredentialRepository in
PasswordAuthenticatorTest, mirroring the production semantics by hand,
and Fellowship kept another. Both are now Unity's one, which carries
the seedPassword() helper the eleven sign-in tests here lean on.

Also corrects the comment naming the binder: Unity declares the
contract, tsml-for-unity supplies the implementation.

6210 of 7194 relevant lines covered (86.32%)

14.37 hits per line

Coverage Regressions

Lines Coverage ∆ File
5
93.33
0.0% reach/reach/src/Auth/PasswordAuthenticator.php
1
88.46
-0.43% reach/reach/src/Core/Schema.php
Jobs
ID Job ID Ran Files Coverage
1 34001248867.1 92
86.32
GitHub Action Run
Source Files on build 34001248867