mindersec / minder / 33986659900

62%

push

github

Surface the HTTP status when REST remediation fails (#6747)

* Surface the HTTP status when REST remediation fails

When the provider's Do returns a non-2xx response without an error
(the generic REST and GitLab providers pass responses through as-is),
the status-code translation formatted the known-nil request error, so
the stored remediation detail read "remediation failed: %!s(<nil>)"
and the mapped status error was discarded. Include the status code and
the translated error in the failure message instead.

Add a regression test that drives run() through a provider whose Do
returns the response as-is; it reproduces the nil-format message
without this fix.

* Move status translation next to error handling

Review feedback: the non-2xx translation sat below the deferred body
close, away from the request error handling. Move the defer up with a
nil guard (which also closes the body when a provider returns both a
response and an error) and translate the status right after the error
block.

5 of 7 new or added lines in 1 file covered. (71.43%)

21662 of 34987 relevant lines covered (61.91%)

39.7 hits per line