ossia / libossia / 33976942710

52%

Build Type

push

github

Committed by jcelerier

Commit Message

dataflow: make the units on a port mean something

Units were declared all over the place and acted upon almost nowhere.

filter_value() read the source type on both sides of its comparison, so an
inlet never converted anything: a port asking for orientation.euler on a
quaternion address received the raw quaternion. A conversion whose result
is invalid - a parameter declared color.rgb fed a plain float, which
make_value() cannot represent - keeps what came in.

On the way out, the branch of map_value_to_param() that runs whenever a
port has a unit built its typed_value from the value alone, dropping both
the unit and the index, so the message reached ossia::message::launch()
with nothing to convert by and metres landed in a millimetre address as
metres. The unit and index now travel to the message. Two typed_value
constructors dropped the timestamp while every sibling kept it.

A port's unit had two sources with one field to hold them: what the node
declares (a colour port is rgba, a gain decibels) and what the port's
address asks for with @[unit]. The second was written straight into the
first, so clearing an address destroyed the node's own declaration and a
new address without a qualifier left the old unit behind. They are now
separate - `type` and `address_unit`, combined by effective_type() - and
only the override goes away with the address.

A unit conversion and a domain mapping are not the same kind of operation.
A unit says what the numbers are and converting preserves the quantity;
mapping between two domains deliberately rescales it. Doing both scaled
the value with bounds expressed in the unit it had just left: one metre
into a millimetre port ranged [0;1] came out as 500. So when both sides
declare a unit of the same dataspace, the conversion has said everything
there is to say and the sink's domain, if it has one, bounds the result
instead - 1000 mm, clipped to 1. This holds the same way on every path:
the address pull, the event pull, t... (continued)

Coverage Stats

635 of 654 new or added lines in 8 files covered. (97.09%)

7 existing lines in 2 files now uncovered.

31449 of 60233 relevant lines covered (52.21%)

175200.95 hits per line