bleedingdeacons / tsml-for-unity / 33976272006
94%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 59
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 94.114% (+0.005%) from 94.109%
33976272006

push

github

web-flow 
fix: guard against get_posts() returning ids rather than WP_Post objects

Three repositories merge caller-supplied $args over their defaults and
hand the result to get_posts(), then read $post->ID on every element:

    $queryArgs = array_merge($defaultArgs, $args);
    $posts = get_posts($queryArgs);
    foreach ($posts as $post) { ... $post->ID ... }

get_posts() returns int[] rather than WP_Post[] when 'fields' => 'ids'
is passed, and because the caller's args win the merge, a caller can
pass exactly that. Today that is a fatal error on an int -- or a
TypeError, since createMeetingFromPost() type-hints WP_Post. It is a
real latent bug rather than a type-checker complaint.

php-stubs/wordpress-stubs v7.1.0 models that conditional return type
where v6.9.4 did not, which is why PHPStan started reporting it against
the Dependabot bump. Each site now filters to WP_Post before use.

Fixing it surfaced the same class of defect in the tests. Two of them
stubbed get_posts() returning (object) ['ID' => 1] -- a bare stdClass,
a shape get_posts() never returns and one createMeetingFromPost() would
refuse anyway. They now use the repository's own WP_Post stub, so they
exercise the shape production actually sees.

Verified against both dependency sets -- main's stubs v6.9.4 with
PHPStan 2.2.7, and the bump's v7.1.0 with 2.2.13 -- with 667 tests
passing, PHPStan and PHPCS clean on each.

3262 of 3466 relevant lines covered (94.11%)

5.93 hits per line

Coverage Regressions

Lines Coverage ∆ File
1
98.05
0.01% tsml-for-unity/tsml-for-unity/src/Members/TsmlMemberRepository.php
Jobs
ID Job ID Ran Files Coverage
1 33976272006.1 59
94.11
GitHub Action Run
Source Files on build 33976272006