33976268480
91%

Ran 05 Sep 2026 03:58PM UTC

Jobs 1

Files 25

Run time 1min

Badge

Embed ▾

Committed 05 Sep 2026 03:55PM UTC coverage: 91.186% (-0.08%) from 91.263%

Build # 33976268480

Build Type

push

github

Committed by

web-flow

Commit Message

fix: expect createNew() in the two tests that were passing for the wrong reason

PositionImporterFailureTest::a_wp_error_from_post_insert_is_skipped and
PositionImporterTest::a_create_whose_post_insert_fails_is_skipped both
reach PositionFactory::createNew(), and neither set an expectation for
it. They always did. Mockery threw BadMethodCallException, the
importer's own error handling caught it, and the row was recorded as
skipped -- which is exactly what these tests assert, so they passed
while proving nothing about the failure they name.

Nothing broke. Mockery 1.6.15 began reporting swallowed
BadMethodCallExceptions as risky, and phpunit.xml.dist sets
failOnRisky="true", so a latent defect became a red gate. Confirmed by
running the same test against both versions: OK on 1.6.12, risky on
1.6.15, with no change to the code under test.

Both now set the expectation their sibling tests already had, so the
skip is caused by wp_insert_post returning a WP_Error (or 0) rather
than by the mock exploding.

Verified against both dependency sets -- main's 1.6.12 and the bump's
1.6.15 -- with 308 tests passing, no risky tests, PHPStan and PHPCS
clean on each.

Coverage Stats

2369 of 2598 relevant lines covered (91.19%)

7.53 hits per line

Coverage Regressions

Lines	Coverage	∆	File
6	91.81	-0.71%	reconcile/reconcile/src/Position/PositionImporter.php

Jobs

ID	Job ID	Ran	Files	Coverage
1	33976268480.1	05 Sep 2026 03:58PM UTC	25	91.19	GitHub Action Run

bleedingdeacons / reconcile / 33976268480
91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 33976268480

bleedingdeacons / reconcile / 33976268480 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 33976268480

bleedingdeacons / reconcile / 33976268480
91%

README BADGES
x