codeigniter4 / CodeIgniter4 / 33968211101

90%

push

github

fix: Memcached `decrement()` gives the wrong sign on a missing key (#10512)

* fix: MemcachedHandler::decrement() wrong sign on missing key

MemcachedHandler::decrement() passed $offset as Memcached::decrement()'s
initial_value, which is used as-is (not decremented from) when a key
doesn't exist yet. That made a fresh key end up at +$offset instead of
the -$offset every other cache handler (File, Redis, Predis) produces.

Memcached counters are unsigned, so they can't hold a negative initial
value the way the other handlers effectively can. Use 0 instead (also
Memcached::decrement()'s own default), so a fresh key at least stops
going the wrong direction.

Updates the existing MemcachedHandlerTest::testDecrement() expectation
and adds a changelog entry.

* fix: address review feedback on Memcached decrement() fix

* fix: correct expected type in MemcachedHandlerTest::testDecrement

1 of 1 new or added line in 1 file covered. (100.0%)

22609 of 25129 relevant lines covered (89.97%)

215.77 hits per line