GrottoCenter / grottocenter-api / 33921138230

91%

push

github

test(search): derive authorsSort survival from the helper, not trim()

nonEmptyNamesArb gated on `n.trim().length > 0`, but normalizeName strips
combining marks before trimming, so a name made purely of diacritics is
non-blank to trim yet normalizes to nothing. U+1FDD decomposes under NFKD to a
space plus two combining marks and leaves nothing behind, so the filter handed
it to the properties as "authored" while the helper correctly returned the
authorless key — failing Property 2 on ~0.25% of seeds.

Ask computeDocumentAuthorsSort itself whether a list survives instead of
re-implementing its normalization in the precondition. The behaviour under test
is unchanged and the filter still keeps ~63% of generated lists, spanning every
script the arbitrary covers.

5236 of 6283 branches covered (83.34%)

Branch coverage included in aggregate %.

9629 of 10729 relevant lines covered (89.75%)

148.26 hits per line