bleedingdeacons / link / 33908985476
92%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 11
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 80.548% (-4.0%) from 84.573%
33908985476

push

github

web-flow 
feat: every sign-in method Hand has, including a password (#11)

Four providers and a password, in that order and for that reason:
nearly every member signs in with a button and never has a password at
all. The password is for the member whose intergroup address is not a
Google, Microsoft, Apple or Facebook account, who otherwise has no way
in.

Google, Microsoft and Facebook are one command with a parameter rather
than three commands. The flow is genuinely identical -- a system browser,
a one-time code caught on the custom scheme, an exchange over TLS -- and
which provider it is is Fellowship's business, not this side's. Three
copies is how two of them end up subtly different. Apple keeps its own
command because its sheet hands over a token with no browser at all.

The password is sent and forgotten. There is no remember-me: a password
kept on a handset to save typing is a password waiting to be read off
it, and the field is cleared whether the sign-in worked or not.

Setting a password is deliberately not signing in. The member asks for a
code, types it with a new password, and is returned to the buttons to
use it -- so a code that reaches the wrong handset cannot enrol it. The
section is collapsed until asked for, because showing it permanently
would suggest a password is expected.

Notices are separate from errors. 'If that address belongs to a member,
a code is on its way' is not a failure and must not be painted as one --
and it is what the app has to say either way, because the server will
not reveal which addresses belong to members.

The page scrolls now. Five methods plus a set-password section does not
fit a small phone in landscape, and a screen that cannot reach its own
submit button is worse than a longer one.

Also clears four analyser warnings from the Apple work: the partial
property became a partial method, which the analysers can follow across
platform files.

617 of 766 relevant lines covered (80.55%)

5.88 hits per line

Coverage Regressions

Lines Coverage ∆ File
81
69.4
-7.63% Services/FellowshipClient.cs
8
80.49
-10.94% Services/Interfaces/IFellowshipClient.cs
Jobs
ID Job ID Ran Files Coverage
1 33908985476.1 11
80.55
GitHub Action Run
Source Files on build 33908985476