Teamwork / utils / 33893116752

77%

push

github

goutil: handle Windows paths in ResolvePackage and ResolveImport (#91)

* goutil: handle Windows paths in ResolvePackage and ResolveImport

Two path helpers assumed Unix conventions, so both misbehave on a Windows
checkout.

ResolvePackage switched on path[0] and only treated a leading '/' as a
directory. A Windows absolute path starts with a drive letter, so it fell
through to build.Import and was resolved as though it were an import path,
which always fails.

ResolveImport's same-package fallback derived the current package name with
path.Base(path.Dir(file)). The path package is slash-only, so for
C:\src\pkg\file.go it evaluates to "." and the fallback never fires,
leaving same-package type references unresolvable.

Both are fixed with helpers that accept either convention, so they are
unit-testable on any host rather than only on Windows. No behaviour change
for Unix paths.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* httputilx: serve TestFetch's fixtures locally instead of httpbin.org

TestFetch drove its status-code cases off httpbin.org, which returns 503
often enough to fail unrelated builds — it failed on this branch while
passing on a re-run of the same commit.

An httptest server now serves the 400/500/418 responses, and the
connection-failure case dials a closed local port rather than relying on a
domain never resolving, which a wildcard DNS resolver can defeat.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

14 of 16 new or added lines in 1 file covered. (87.5%)

1296 of 1686 relevant lines covered (76.87%)

35.2 hits per line