aas-core-works / aas-core-codegen / 33892416086

85%

push

github

Simplify XML de-serialization in Java (#674)

We refactor the Java XML de-serialization to remove duplicated
boilerplate, mirroring the TypeScript (#671), C# (#672), C++ (#673)
and Go simplifications.

List-property parsing used to be one inline while-loop generated per
list-typed property. We introduce a shared generic `parseList<T>`
helper, and every list property now just calls it with an item
deserializer method reference instead of duplicating the loop.

Class-from-element parsing used to bundle the open-tag read, the
close-tag check, and the dispatch (either a single expected-name
check for a leaf class, or a switch over implementers for an
interface) inline in every generated `try{Cls}FromElement` and
`try{Interface}FromElement` function. We factor the open/close-tag
handling into one shared generic `parseInstanceFromElement<T>`
function; each per-class/-interface function now only supplies the
small dispatch lambda.

This also fixes a redundancy in the previous design: an interface's
dispatch used to route through the full `FromElement` of the chosen
implementer, which re-read and re-verified the open tag the
interface dispatcher had already read. The switch now calls
`FromSequence` directly, so the open and close tag are each handled
exactly once per polymorphic deserialization, not once per
implementer.

7 of 7 new or added lines in 1 file covered. (100.0%)

30893 of 36496 relevant lines covered (84.65%)

2.54 hits per line