archetech / archon / 33889462713

95%

push

github

fix(zcash-wallet): Read the consensus branch from the node, and announce broadcasts (#1042)

* fix(zcash-wallet): Read the consensus branch from the node

Zcash signatures commit to the consensus branch id (ZIP-243), so one made
under a superseded network upgrade is rejected at consensus validation as
ScriptInvalid. The branch was pinned in source to NU6.1, and a mainnet node
stopped anchoring the day NU6.2 activated: four successful anchors, then
nothing from 2026-05-22 through NU6.3 (#1040).

Choosing a newer constant would not have fixed it. The installed
@bitgo/utxo-lib knows branches up to NU6.2 (0x5437f330) and the chain is on
NU6.3 (0x37a5165b), and pinning any value reintroduces this at the next
upgrade -- Zcash has activated three since NU6. Mainnet and testnet are also
on different branches at present, so no single constant serves both.

The node already reports the branch the next block will use, so it is read
from there. setDefaultsForVersion still takes a VERSION4_BRANCH_* constant,
because it rejects a bare 4 and derives the Sapling version group id from it;
setConsensusBranchId then replaces the branch that constant implies. Verified
against a live mainnet node: the helper derives 0x37a5165b, which is what the
chain reports.

Signing refuses rather than guessing when the node reports no branch. A wrong
branch produces a transaction the network rejects, so nothing is lost either
way, but failing at the wallet says which.

The existing anchor test caught a first attempt at this that passed a bare 4
to setDefaultsForVersion. Its stub now serves getblockchaininfo, without
which the anchor path is unreachable.

Closes #1040.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYGMfX3foBcVqP7AQNXjWj

* fix(zcash-wallet): Require a full branch id rather than a parseable prefix

parseInt takes a valid prefix, so "37a5165bgarbage" and "0x37a5165b" both
produced a usable number, and "1" produced... (continued)

3881 of 4464 branches covered (86.94%)

Branch coverage included in aggregate %.

8528 of 8953 relevant lines covered (95.25%)

717.59 hits per line