forzagreen / n2words / 33889183232

99%

push

github

fix(es-ES,es-US): apocopate "uno" before a noun — 21000 is "veintiún mil" (#447)

Spanish shortens "uno" to "un" (and "veintiuno" to "veintiún",
"treinta y uno" to "treinta y un") whenever the numeral immediately
precedes a masculine noun. Every scale word and every currency name sits
in exactly that position, but both Spanish implementations only
special-cased a *bare* segment of 1 ("un millón"), so any segment merely
*ending* in 1 kept the full form: "veintiuno mil", "ciento uno millones",
"veintiuno euros".

buildSegment now takes an `apocopate` flag, set for every segment that
multiplies a scale word, and integerToWords takes `beforeNoun`, which
carries it to the trailing segment when a currency name follows. Feminine
ignores both — "veintiuna casas" doesn't apocopate — and a standalone
numeral is unaffected, so toCardinal(21) is still "veintiuno" and so is
the tail of "veintiuno punto veintiuno".

es-MX and es inherit the fix as a locale profile and a bare-tag alias of
es-ES. Checked differentially over 28k values across both variants and
both genders: all 5076 changed outputs differ only by that substitution,
and injectivity still holds.

Closes #446

5425 of 5658 branches covered (95.88%)

Branch coverage included in aggregate %.

79 of 79 new or added lines in 2 files covered. (100.0%)

30955 of 31146 relevant lines covered (99.39%)

1300.68 hits per line