AfterShip / clickhouse-sql-parser / 33878941170

56%

Build Type

push

github

Committed by web-flow

Commit Message

Support SETTINGS in ALTER TABLE ADD INDEX and fix IF NOT EXISTS placement (#319)

ADD INDEX had no SETTINGS clause, so a statement such as

  ALTER TABLE t ADD INDEX IF NOT EXISTS idx c TYPE minmax
    GRANULARITY 1 SETTINGS alter_sync = 2

failed to parse, while ADD COLUMN and the partition clauses already
accepted one. Parse it the same way they do.

The formatter also wrote the clause as `ADD IF NOT EXISTS INDEX`, which
ClickHouse rejects, so formatted output could not be parsed again. Split
the part of TableIndex.FormatSQL that follows the INDEX keyword so
ALTER TABLE can emit `ADD INDEX IF NOT EXISTS` instead.

Both forms were verified against clickhouse-local 26.8.2.7.

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>

Coverage Stats

19 of 27 new or added lines in 4 files covered. (70.37%)

1 existing line in 1 file now uncovered.

9568 of 17035 relevant lines covered (56.17%)

4074.86 hits per line