ponder-lab / Hybridize-Functions-Refactoring / #3030

86%

push

github

Keep container element evidence when withholding a signature (#940)

The unrepresentable-element scan added in #938 lives inside
`extractContainerElements`, and it returned as soon as it found a null
member. That return landed before the extraction below it, so the very
containers the scan describes lost their element types entirely: rows
reporting a container parameter came out with an empty `container
element types` column.

The flag and the evidence answer different questions. The flag decides
whether a specification is withheld, while the element types record what
the analysis saw, and withholding an output is not a reason to stop
reporting an observation. End the scan instead of the method.

Measured on a fixed subject with Ariadne held at 0.52.90, so the
consumer is the only variable: three parameter rows regained their types
and the population returned to its baseline exactly.

The suite cannot see this. The affected column is produced by the
evaluator rather than the refactoring, so no fixture covers it, and the
#938 fixture passes either way. It was found by comparing evaluator
populations across releases.

2 of 2 new or added lines in 1 file covered. (100.0%)

3608 of 4225 relevant lines covered (85.4%)

0.85 hits per line