source-academy / frontend / 33821276299

45%

Build Type

push

github

Committed by web-flow

Commit Message

Exclude prepend from Conductor testcase error line numbers (#4291)

* Exclude prepend from Conductor testcase error line numbers

runTestCaseConductor concatenates prepend/value/postpend/testcase into one
file before sending it to the Conductor evaluator, but unlike evalCode.ts's
Run-path fix for the same off-by-N bug (#4244), nothing subtracted the
prepend's line count back out of a resulting error's reported line - so an
error on the student's own first line was reported at `prepend line count +
1`. evalCodeConductorSaga's own prepend-offset correction doesn't reach this
path: it's gated on an editor Run's actionType, and runTestCaseConductor
calls evalCodeSaga with EVAL_SILENT instead. Shift the line back out locally
in runTestCase.ts instead, using the same prepend value this saga already
concatenated into the combined file.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FYm9pttcp3nixtDLKiPh2k

* Fix formatting (oxfmt)

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FYm9pttcp3nixtDLKiPh2k

---------

Co-authored-by: Shrey Jain <“shreyjain5132@email.com>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: Martin Henz <henz@comp.nus.edu.sg>

Coverage Stats

3133 of 7877 branches covered (39.77%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 1 file covered. (100.0%)

3 existing lines in 1 file now uncovered.

7110 of 14654 relevant lines covered (48.52%)

31.07 hits per line