stacklok / toolhive / 33807055651

73%

Build Type

push

github

Committed by web-flow

Commit Message

Bound and drain hand-rolled HTTP transport pools (#6495)

* Bound and drain hand-rolled HTTP transport pools

#6480 bounded and drained only the clients built by
networking.HttpClientBuilder.Build. Several hand-rolled
&http.Transport{} literals elsewhere left IdleConnTimeout at zero, so a
pooled idle connection never expired and a dropped client pinned a
socket plus its goroutine pair for the process lifetime. Separately,
several wrapping RoundTrippers did not implement CloseIdleConnections,
so http.Client.CloseIdleConnections type-asserted the outermost
transport, missed the method, and silently became a no-op.

Implements changes for issue #6483:
- Bound the transport literals in pkg/auth/discovery, pkg/auth/oauth,
  and pkg/oauthproto (discovery, dcr) with the same host-scoped pool
  bounds Build applies
- Add networking.ForwardCloseIdle so a wrapping RoundTripper forwards
  CloseIdleConnections without an ad-hoc anonymous assertion; use it
  from ValidatingTransport and the vmcp wrappers
- Forward CloseIdleConnections from bearerTokenTransport,
  registry/auth.Transport, and oauthproto.UserAgentTransport (the last
  inline, since pkg/oauthproto cannot import pkg/networking)

pkg/authz/authorizers/http builds no wrapper and uses http.DefaultTransport
(or its Clone), which is already bounded and forwards the call, so it needs
no change.

* Centralize idle-pool bounds and cover them with tests

Addresses stacklok/toolhive#6495 review comments:
- MEDIUM pkg/oauthproto/dcr.go (3925404488): the 90s/100/4 pool values
  were duplicated across five transport literals with only a comment to
  keep them in sync. Add networking.SetIdleConnBounds as the single
  source (Build now uses it too); the three cycle-free sites call it, and
  the two oauthproto leaf sites reference a local const block since
  pkg/networking imports pkg/oauthproto.
- MEDIUM pkg/auth/discovery/discovery.go (3925404500): the two
  discovery.go transports and the oidc.go transport shipped... (continued)

Coverage Stats

63 of 67 new or added lines in 11 files covered. (94.03%)

13 existing lines in 3 files now uncovered.

77757 of 111123 relevant lines covered (69.97%)

92.34 hits per line