decentraland / builder / 33800829456

53%

push

github

feat: list collections through the newest off-chain marketplace (#3473)

* feat: list collections through the newest off-chain marketplace

Grants minter rights to the newest marketplace version deployed on the chain
rather than always V2, so testnet listings go through V3 while mainnet keeps
using V2 until V3 ships there. The authorization modal labels whichever
version was resolved.

isEnableForSaleOffchain now accepts any deployed version as the minter, not
just V1 or V2. Narrowing it to the current version would make every
collection listed through an older marketplace look unlisted.

The resolution deliberately mirrors decentraland-dapps' getTradeSignature and
has to stay in step with it: the marketplace granted minter rights is the one
that mints the item, so it must be the version the trade was signed against.

* fix: revoke every held marketplace version when disabling off-chain sale

enableSaleOffchain only revoked the newest version, so a collection holding
V2 minter rights kept them after the user turned off-chain sale off: listings
on that version stayed sellable, and isEnableForSaleOffchain - which accepts
any deployed version - still reported the collection as on sale.

Enabling still grants the newest version only, since the minter has to be the
contract the trade was signed against. Disabling now revokes every version
the collection actually holds, falling back to the newest when it holds none
so the contract never receives empty arrays.

* chore: pick up decentraland-dapps 29.7.1

29.7.1 is the first release where getTradeSignature signs against the newest
deployed marketplace rather than V2. Until now Builder granted minter rights to V3
on testnets while dapps still signed the trade against V2, so the authorized minter
was not the contract that settles and a primary listing reverted at mint.

Adds the cross-package regression test promised on #3472: the address Builder
authorizes has to equal the one dapps builds its EIP-712 domain f... (continued)

2627 of 6250 branches covered (42.03%)

Branch coverage included in aggregate %.

32 of 37 new or added lines in 4 files covered. (86.49%)

7911 of 13686 relevant lines covered (57.8%)

36.7 hits per line