MITLibraries / alma-sapinvoices-ui / 33795014151

87%

main: 87%

Build Type

Pull #152

github

Committed by ghukill

Commit Message

Remove ECS task definition revision and existence handling

Why these changes are being introduced:

We no longer pass a revision in the task definitino ARN, which is set
via env var `ALMA_SAP_INVOICES_ECS_TASK_DEFINITION`.  Given that we're leaning
on the default revision for this task definition, we also don't need quite as much
existence checking for a specific revision.

How this addresses that need:
* Removes all handling of task revision from task definition ARN
* Removes checks for task definition existence; accept a bad env var task definition
will bubble up an error directly on run

Relevant ticket(s):
* https://mitlibraries.atlassian.net/browse/IN-1368

Pull Request Pull Request #152: IN 1368 - propagate tags

Coverage Stats

3 of 3 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

290 of 335 relevant lines covered (86.57%)

0.87 hits per line