scikit-hep / pyhepmc / 33772771424

97%

push

github

feat: update vendored HepMC3 to 3.3.1 (#121)

Fixes #110, which bumps from 3.2.5(+38) to the 3.3.1 tag. `pdf_info` on
events read from LHE files needs upstream commit dbef899, which landed
in 3.3.0. After the bump, reading `tests/pp.lhe` gives an event with
`GenPdfInfo(parton_id1=3, parton_id2=22, ..., scale=91.1876)`.

Two things needed adjusting:

1. **`GenCrossSection::set_cross_section` is now an overload set**, so
the bare member pointer in `core.cpp` will no longer be compiled. The
binding now uses `py::overload_cast` and exposes both variants.

2. **The LHEF read-inversion patch in `io.py` had to go.** In 3.2.5,
`ReaderLHEF::read_event` returned false on success (upstream issue
[#46](https://gitlab.cern.ch/hepmc/HepMC3/-/issues/46)), and `io.py`
carried `_read_event_lhef_patch` to invert the return value. Upstream
fixed the semantics, so the patch was now inverting a correct value and
every LHE read came back empty. With the fix, `ReaderLHEF` goes through
the same `ReaderMixin` path: **94 passed**.

### Regression test

Added `test_open_5_pdf_info`, which asserts the `pdf_info` fields and
the vertex count on `tests/pp.lhe`. Against the old `io.py` it fails
with `StopIteration`, so it does guard the fix.

---------

Co-authored-by: Eduardo Rodrigues <eduardo.rodrigues@cern.ch>

0 of 3 new or added lines in 1 file covered. (0.0%)

481 of 497 relevant lines covered (96.78%)

0.97 hits per line