amboss-mededu / gateway / 33768003775

93%

master: 91%

Build Type

Pull #18

github

Committed by cideM

Commit Message

forward operation directives to declaring services

The planner rebuilds each step's operation from scratch and never copied
the client operation's directives onto it, so a directive in the
operation position was dropped before any service saw it. A client
sending

    query Articles @capiRelationMap { article { title author { name } } }

got a plan whose steps read `query Articles { ... }`, and the service
that declares @capiRelationMap to opt into a different response shape
never learned the client had asked for it. Nothing surfaced: the merged
schema declares the directive, so validation passed, and the request
succeeded with the default behaviour.

Copying the directives verbatim onto every step is not a fix either. A
GraphQL server rejects the whole query if it carries a directive it does
not declare, or one in a position its declaration does not allow. Only
the services that declare the directive for the position it lands in may
receive it.

The position is the step's own operation type, not the client's. A
dependent step re-enters a service through node(id:), which is a Query
field, so it always executes as a query even when the client sent a
mutation. Given both services declaring `directive @audit on MUTATION`
and

    mutation CreateUser @audit { createUser { firstName lastName } }

with lastName owned by the second service, the dependent step must not
carry @audit or that service rejects it with "directive @audit is not
allowed on QUERY".

Index each source schema's declared directives and their allowed
locations by URL once at startup. Sources sharing a URL are unioned:
nothing rejects a configuration that splits one service across two
RemoteSchema entries, and fieldURLs already registers fields from both,
so keying by URL alone would keep whichever entry came last. The index
reads source schemas rather than the merged one, so it is independent of
how the merger reconciles directive definitions.

When a step's query document is built, filt... (continued)

Pull Request Pull Request #18: planner: forward operation directives to declaring services

Coverage Stats

57 of 63 new or added lines in 2 files covered. (90.48%)

105 existing lines in 3 files now uncovered.

2742 of 2962 relevant lines covered (92.57%)

419.81 hits per line