urwid / urwid / 33763199825

90%

push

github

Stop CanvasCache._deps growing without bound (#1255)

store() appends the dependent widget to _deps[w] on every single
render, not just the first time a dependency relationship shows up.
A widget that gets rendered repeatedly (which is the normal case for
anything on screen, since each redraw calls store() again) ends up
with the same entry piling up in that list forever, since nothing
ever removes a duplicate, only invalidate() clears the whole entry.
For a long-running program that redraws frequently this grows
without limit.

Switched the list to a set so each dependent widget only ever
appears once per dependency, regardless of how many times it gets
rendered. invalidate() still walks every entry and clears the whole
mapping the same way, this only changes how duplicates are handled.

3470 of 5240 branches covered (66.22%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

9568 of 12500 relevant lines covered (76.54%)

7.89 hits per line