accordproject / concerto / 33740930050

98%

push

github

fix(concerto-cto): reject duplicate validators instead of silently keeping the last (#1314)

The any-order validator collection introduced in #1305 buckets validators
by $class with plain assignment, so regex=/a/ regex=/b/ now parses and
silently drops /a/. The same applies to length, range and size, on both
fields and scalars; before #1305 the grammar rejected all of these. A
modeler's constraint being silently discarded weakens validation.

The grammar initializer gains a bucketValidators helper that raises a
located 'Duplicate <kind> validator' error on a repeat, used by all five
reducer rules. src/parser.js regenerated with npm run parser, matching the
convention of committing the generated parser.

Seven tests added covering duplicate regex, length, range (Integer, Double,
Long) and size on fields plus regex on a scalar; all fail on the unfixed
grammar and every any-order valid case from #1305 still parses.

Signed-off-by: rajanpanth <rajan.pantha@samriddhicollege.edu.np>

2177 of 2264 branches covered (96.16%)

Branch coverage included in aggregate %.

3969 of 4007 relevant lines covered (99.05%)

135217.29 hits per line